Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should bamboo plots be moved to a "plots/" subdirectory? #36

Closed
samreid opened this issue Jun 15, 2021 · 3 comments
Closed

Should bamboo plots be moved to a "plots/" subdirectory? #36

samreid opened this issue Jun 15, 2021 · 3 comments
Assignees
@samreid
Labels
status:on-hold type:question Further information is requested

Comments

@samreid
Copy link
Member

samreid commented Jun 15, 2021

Inspired by #34 and #35 it seems possible that we will have a proliferation of plot types in bamboo. Should these be moved to a "plots" subdirectory, or is it preferable to keep everything top-level?

@pixelzoom what do you recommend?
@samreid samreid added the type:question Further information is requested label Jun 15, 2021
@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 15, 2021 •
edited
Loading

I don't feel strongly either way.

@pixelzoom pixelzoom assigned samreid and unassigned pixelzoom Jun 15, 2021
@samreid
Copy link
Member Author

samreid commented Jun 15, 2021

I'll consider this after factoring out a plot supertype in #35

@samreid
Copy link
Member Author

samreid commented Jul 10, 2021

I don't feel strongly about putting Plots in a subdirectory. Maybe in the future if there are too many things, we can reconsider. Closing.

@samreid samreid closed this as completed Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:on-hold type:question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @pixelzoom