From 55afd48457e5e7888926d45996e298995bde47f8 Mon Sep 17 00:00:00 2001 From: pixelzoom Date: Tue, 12 Jan 2021 10:30:28 -0700 Subject: [PATCH] TODOs for https://github.com/phetsims/bamboo/issues/21 --- js/SpanNode.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/js/SpanNode.js b/js/SpanNode.js index 0a357a3..f74bdbc 100644 --- a/js/SpanNode.js +++ b/js/SpanNode.js @@ -36,7 +36,7 @@ class SpanNode extends LayoutBox { assert && assert( typeof delta === 'number', 'invalid delta' ); assert && assert( labelNode instanceof Node, 'invalid labelNode' ); - //TODO https://github.com/phetsims/bamboo/issues/19 support Orientation.VERTICAL + //TODO https://github.com/phetsims/bamboo/issues/21 support Orientation.VERTICAL assert && assert( axisOrientation !== Orientation.VERTICAL, 'Orientation.VERTICAL is not yet supported' ); options = merge( { @@ -94,7 +94,7 @@ class SpanNode extends LayoutBox { if ( Math.abs( viewWidth - this.viewWidth ) > notificationThreshold ) { this.viewWidth = viewWidth; - //TODO https://github.com/phetsims/bamboo/issues/19 arrow code only works for axisOrientation === Orientation.HORIZONTAL + //TODO https://github.com/phetsims/bamboo/issues/21 support Orientation.VERTICAL //TODO https://github.com/phetsims/bamboo/issues/19 parameterize length of lines at ends of arrow //TODO https://github.com/phetsims/bamboo/issues/19 parameterize ArrowNode options // Create double-headed arrow with bars at to show modelDelta @@ -113,7 +113,7 @@ class SpanNode extends LayoutBox { children: [ leftBar, rightBar, arrowNode ] } ); - //TODO https://github.com/phetsims/bamboo/issues/19 maxWidth only works for axisOrientation === Orientation.HORIZONTAL + //TODO https://github.com/phetsims/bamboo/issues/21 support Orientation.VERTICAL // Prevent labelNode from being wider than arrowWithBars this.labelNode.maxWidth = arrowWithBars.width;