Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No charge deflection sound when balloon floats to wall #539

Closed
Tracked by #721
stemilymill opened this issue Sep 14, 2021 · 5 comments
Closed
Tracked by #721

No charge deflection sound when balloon floats to wall #539

stemilymill opened this issue Sep 14, 2021 · 5 comments

Comments

@stemilymill
Copy link

Win10 Chrome and Firefox

phetsims/qa#706
#479

I'm not sure if this is expected behavior, so if it is please close this issue.

When a charged balloon is released and floats towards the wall, there is no charge deflection sound like there would be when the balloon is moved toward the wall by the user.

Steps to Reproduce:

Charge balloon by rubbing across sweater
Move balloon to near the wall
Release balloon so it floats to the wall

With two balloons:
Partially charge both balloons by rubbing each across part of the sweater
Leave one balloon on sweater
Release the other balloon near the wall so it floats to the wall

no.charge.moving.away.sound.mp4
@jbphet
Copy link
Contributor

jbphet commented Sep 14, 2021

The sound design team reviewed this in today's meeting and decided that yes, we should try to address this for the 1.5 release.

@jbphet
Copy link
Contributor

jbphet commented Sep 28, 2021

The sound design team reviewed the modified behavior where:

  1. Charge generation sounds can be produced by a drifting balloon
  2. Balloons don't slide along the wall (see Consider preventing the balloon from sliding along the wall #544)

...and we're good with these changes. I'll run the wall slide change past the main designer before finalizing it.

@jbphet
Copy link
Contributor

jbphet commented Sep 30, 2021

I reviewed this with @arouinfar and she has approved it. The change is already on master, and I'll cherry-pick it to the 1.5 branch since that is an RC that is currently in progress.

@jbphet
Copy link
Contributor

jbphet commented Sep 30, 2021

This has been cherry-picked into the 1.5 release branch, and I'll have it verified in the next release.

@Nancy-Salpepi
Copy link

Charge deflection sounds now heard when drifting balloon floats to wall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants