Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability on small screens review #87

Closed
KatieWoe opened this issue Apr 17, 2019 · 3 comments
Closed

Usability on small screens review #87

KatieWoe opened this issue Apr 17, 2019 · 3 comments
Assignees

Comments

@KatieWoe
Copy link
Contributor

Per @kathy-phet's request in phetsims/qa#295 I am making issues in each published sim repo detailing the pointer areas and usability of sims on phone sized screens. Done on an iPhone 7 iOS 12 device.

Potential Difficulties Noticed:

  • Pointer Areas of bricks in tool box appear even when not in tool box. Clicking/dragging them does not seem to do anything

Screenshots:
Image from iOS (1)
Image from iOS (2)
Image from iOS (3)
Image from iOS (4)
Image from iOS (5)
Image from iOS (6)
Image from iOS (7)
Image from iOS

@arouinfar
Copy link

Thanks @KatieWoe.

This looks similar to the carousel in CCK, see phetsims/circuit-construction-kit-dc#178. @jbphet can you look into this?

@arouinfar arouinfar assigned jbphet and unassigned arouinfar Apr 17, 2019
@jbphet jbphet assigned SaurabhTotey and unassigned jbphet Jun 26, 2019
@SaurabhTotey
Copy link
Member

Looking at the code, it looks like the container used in this simulation is a KitSelectionNode common-code component. Similarly to Carousel, it looks like KitSelectionNode uses clip areas. As such, I believe this issue is almost exactly the same as phetsims/circuit-construction-kit-dc#178. The brick stacks are getting clipped out, but their pointer areas are still getting shown, even though they aren't actually really touchable while clipped out. I believe this issue can consequently be closed, as that is the action that was taken for phetsims/circuit-construction-kit-dc#178. Assigning to @KatieWoe to review.

@KatieWoe
Copy link
Contributor Author

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants