Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering page in studio focuses on seemingly random element #129

Closed
KatieWoe opened this issue May 6, 2021 · 7 comments
Closed

Entering page in studio focuses on seemingly random element #129

KatieWoe opened this issue May 6, 2021 · 7 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented May 6, 2021

Test device
Dell
Operating System
Win 10
Browser
Chrome
Problem description
For phetsims/qa#642. Found in https://phet-dev.colorado.edu/html/balancing-act/1.2.4-rc.1/phet-io/wrappers/studio.
When working in studio, when you enter a page in the sim, the tree focus should move to the top level of that page. However, here it seems to focus on some other element, such as the enabled property of the reset button or the enabled property of the next button in a tool box.

Visuals
studioopenstorandomiterm

@jonathanolson
Copy link
Contributor

I don't have any idea on this one, doesn't seem general. I'm going to unassign and not handle it during this maintenance process.

@jonathanolson jonathanolson removed their assignment May 13, 2021
@jbphet
Copy link
Contributor

jbphet commented May 17, 2021

@samreid and @zepumph - The balancing-act sim is a bit unique in that the phet-io instrumentation effort was done as a bit of a "rush job" to support a requested study, see #96 and #104. I don't know at this point whether we are even providing Studio as part of this release, so I don't know how to evaluate the importance of fixing this GitHub issue. I therefore need your input on it. What would you recommend - does this issue need to be addressed or should it be deferred until a more complete phet-io instrumentation effort is done on this sim?

@jbphet jbphet assigned samreid and zepumph and unassigned jbphet May 17, 2021
@samreid
Copy link
Member

samreid commented May 17, 2021

I'm not sure what explains this behavior, but it doesn't appear to be happening on master. Perhaps it was a temporary bug that leaked into production. In any case it doesn't seem severe or worth addressing in a maintenance release. @jbphet thoughts?

@samreid samreid assigned jbphet and unassigned samreid May 17, 2021
@jbphet
Copy link
Contributor

jbphet commented May 18, 2021

@jbphet thoughts?

It's hard for me to contribute much at this point given my current knowledge of the situation, so let me ask some specific questions:

  • Has this sim been released to the general phet-io-using public in phet-io form, or has it only been released to the specific individuals who requested it in support of their study?
  • If it has not been generally released, do we know whether the people who are using it are using Studio?

If the answer to either one of these questions is yes, we should probably do a bit more investigation. If both are a "no", then I think I would recommend closing without fixing.

@jbphet jbphet assigned samreid and unassigned jbphet May 18, 2021
@samreid
Copy link
Member

samreid commented May 18, 2021

Since balancing act is not mentioned in the PhET-iO links spreadsheet, I think that means it has not been shared to clients generally.

@KatieWoe
Copy link
Contributor Author

Saw this a bit in phetsims/qa#649 in the graphing quadratics sim

@samreid
Copy link
Member

samreid commented Jun 28, 2021

Closing based on the recommendations above.

@samreid samreid closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants