Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropertyStateHandler.propertiesInOrderDependencies should be a Set #318

Closed
zepumph opened this issue Jul 29, 2020 · 1 comment
Closed

PropertyStateHandler.propertiesInOrderDependencies should be a Set #318

zepumph opened this issue Jul 29, 2020 · 1 comment
Assignees
@zepumph
Labels
dev:code-review dev:phet-io

Comments

@zepumph
Copy link
Member

zepumph commented Jul 29, 2020

From #316, the phet-io team sees that Object.<phetioID, {true}> can be rewritten as a Set.
@zepumph zepumph self-assigned this Jul 29, 2020
@zepumph
Copy link
Member Author

zepumph commented Nov 19, 2020

This doesn't apply anymore since refactoring done in #316. Closing

@zepumph zepumph closed this as completed Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
dev:code-review dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph