Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to new approach for Region and Culture #215

Closed
Luisav1 opened this issue Mar 13, 2024 · 3 comments
Closed

Convert to new approach for Region and Culture #215

Luisav1 opened this issue Mar 13, 2024 · 3 comments

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Mar 13, 2024

For phetsims/joist#958.

The changes were done in 970fe8b.

@amanda-phet This needs a design review to ensure the Region and Culture changes were alright. The changes can be seen in main.

@amanda-phet
Copy link
Contributor

amanda-phet commented Mar 13, 2024

The preferences dialog looks how I would expect. Query parameter is working.

Can we make random the default selection for Region & Culture?

@amanda-phet amanda-phet assigned Luisav1 and unassigned amanda-phet Mar 13, 2024
@Luisav1
Copy link
Contributor Author

Luisav1 commented Mar 13, 2024

Although the default in general for R&C is usa (from phetsims/joist#957 (comment)), @amanda-phet confirmed with @kathy-phet that we'll use random as the default when the usa set is only one character, such as this sim.

Oops, I missed #214 that is tracking changing the default to random.

@Luisav1
Copy link
Contributor Author

Luisav1 commented Mar 13, 2024

Closing since this has been reviewed and #214 set the default to random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants