Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sim-specific code with LevelSelectionButtonGroup #196

Closed
pixelzoom opened this issue Oct 6, 2022 · 5 comments
Closed

Replace sim-specific code with LevelSelectionButtonGroup #196

pixelzoom opened this issue Oct 6, 2022 · 5 comments
Assignees
@marlitas
Labels
status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

Related to phetsims/vegas#108 ...

LevelSelectionButtonGroup is a new vegas UI component for creating the level-selection buttons for games. It replaces boilerplate code in sims, and provides a consistent PhET-iO tandem structure. Please convert this sim to use LevelSelectionButtonGroup.
@pixelzoom pixelzoom mentioned this issue Oct 6, 2022
Closed
@jbphet
Copy link
Contributor

jbphet commented Oct 10, 2022

Deferring this until the next time this sim needs to be published from master. At that point, this issue should be un-deferred and addressed.

@marlitas
Copy link
Contributor

This can be addressed in the upcoming region and culture publication. self-assigning.

@marlitas marlitas assigned marlitas and unassigned jbphet Nov 16, 2023
@marlitas marlitas assigned Luisav1 and unassigned marlitas Nov 17, 2023
@marlitas marlitas mentioned this issue Nov 28, 2023
Closed
@marlitas
Copy link
Contributor

marlitas commented Dec 1, 2023

Review for this should probably happen alongside: phetsims/vegas#120. Over to @pixelzoom for review.

@marlitas marlitas assigned pixelzoom and unassigned Luisav1 Dec 1, 2023
@marlitas marlitas assigned Luisav1 and unassigned Luisav1 Dec 1, 2023
@pixelzoom
Copy link
Contributor Author

I reviewed phetsims/vegas#120. But I don't see any arithmetic-specific commits attached to this issue, so don't know what to review for this issue. Back to @marlitas. If reviewing phetsims/vegas#120 was sufficient, feel free to close this issue.

@pixelzoom pixelzoom assigned marlitas and unassigned pixelzoom Dec 6, 2023
@marlitas
Copy link
Contributor

marlitas commented Dec 8, 2023

Ah yes, Sorry about that @pixelzoom. The commit was bundled into the vegas issue. Looks good to go. Thanks!

@marlitas marlitas closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlitas marlitas

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pixelzoom @jbphet @marlitas @Luisav1