Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks grabbed from toolbox may be the wrong size #121

Open
KatieWoe opened this issue Jul 6, 2022 · 1 comment
Open

Blocks grabbed from toolbox may be the wrong size #121

KatieWoe opened this issue Jul 6, 2022 · 1 comment

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Jul 6, 2022

Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
Found during phetsims/qa#817, but unrelated to those changes. This happens in both master and the published version. When grabbing blocks from the toolbox, it is possible for the wrong block to be grabbed. For instance, you try to grab a 2-block, but a 1-block is removed. I haven't found an exact cause yet, but it may be connected to blocks returning to the toolbox and/or when the toolbox has two screens. The steps below seem to reproduce it fairly often, but not always and it isn't the only way.
Marking as deferred and I recommend revisiting if this is ever republished.

Steps to reproduce

  1. Go to the Game screen
  2. Go to the 6th level
  3. Use 4-blocks to build a shape
  4. Remove two blocks and return them to the toolbox. You may see them go to an unexpected spot in the toolbox
  5. Start grabbing blocks from the toolbox, on either screen. The first of that type grabbed may be the wrong type.

Visuals
wrongblocks

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Area Builder‬
URL: https://phet.colorado.edu/sims/html/area-builder/latest/area-builder_en.html
Version: 1.1.22 2022-07-06 06:38:40 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/103.0.0.0 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {"area-builder":{"sha":"5c4ff2f3","branch":"HEAD"},"assert":{"sha":"7d27130a","branch":"HEAD"},"axon":{"sha":"5e33541f","branch":"HEAD"},"babel":{"sha":"a15097ca","branch":"master"},"brand":{"sha":"101869d9","branch":"HEAD"},"chipper":{"sha":"7a2d4f58","branch":"HEAD"},"dot":{"sha":"bf6f038b","branch":"HEAD"},"joist":{"sha":"b9d398b4","branch":"HEAD"},"kite":{"sha":"dce9765e","branch":"HEAD"},"phet-core":{"sha":"745d5fbb","branch":"HEAD"},"phetcommon":{"sha":"99c3655b","branch":"HEAD"},"phetmarks":{"sha":"3fdfece0","branch":"HEAD"},"scenery":{"sha":"d2bc7caf","branch":"HEAD"},"scenery-phet":{"sha":"7def38a3","branch":"HEAD"},"sherpa":{"sha":"a7ccb78f","branch":"HEAD"},"sun":{"sha":"9f2d40d5","branch":"HEAD"},"tandem":{"sha":"0ad35fb7","branch":"HEAD"},"vegas":{"sha":"32591f0e","branch":"HEAD"},"vibe":{"sha":"b7f457e4","branch":"HEAD"}}

@jbphet
Copy link
Contributor

jbphet commented Jul 6, 2022

This is marked as deferred since, in my opinion, it isn't worth a maintenance release or a lot of investigation time. It can be investigated and potentially fixed the next time we perform a release of this sim off of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants