Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate stepper option to Carousel #106

Closed
pixelzoom opened this issue Aug 24, 2018 · 1 comment
Closed

evaluate stepper option to Carousel #106

pixelzoom opened this issue Aug 24, 2018 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

Carousel was converted to use TWIXT/Animation in phetsims/sun#381. The default is stepper: 'manual', which means that the client must call step to control the Carousel's animation. To avoid having to make changes in this sim, stepper: 'timer' was added to Carousel call sites, which means that the animation will run automatically using the sim Timer.

The responsible developer should evaluate what stepper value should be used.

@jbphet
Copy link
Contributor

jbphet commented Aug 27, 2018

I've looked at the code, and I think I'll leave the stepper value set to timer. This is pretty much how the original implementation worked, and the carousel isn't tracked as a property or variable inside AreaBuilderGameView, and it doesn't seem to me to be worthwhile to change this. I tested it on master and the carousel appears to work fine. Closing.

@jbphet jbphet closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants