Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for testing dependencies between common code #111

Open
zepumph opened this issue Dec 10, 2020 · 1 comment
Open

Add a test for testing dependencies between common code #111

zepumph opened this issue Dec 10, 2020 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Dec 10, 2020

From phetsims/tambo#126 (comment), we would like to have a test like the following:

  • Build sun
  • Test the dependencies it imported
  • Make sure it doesn't include sims or joist (maybe others).

@jonathanolson made it sound like this would involve a new CT test type that runs Node code. I think that could be valuable in other places as well, not just this dependency test (perhaps make a new issue to support this)? For example, I don't know if chipper's command line qunit test is currently run on CT.

@jonathanolson what would like to do here?

@jonathanolson
Copy link
Contributor

I don't know if chipper's command line qunit test is currently run on CT.

It isn't currently.

Presumably we'd want to add a test type for aqua, and potentially be able to add essentially a prompt to say "Build repo X, make sure it doesn't depend on repos Y,Z,W"

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants