Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial gradient split failure with EdgedFace #7

Open
jonathanolson opened this issue Oct 14, 2023 · 1 comment
Open

Radial gradient split failure with EdgedFace #7

jonathanolson opened this issue Oct 14, 2023 · 1 comment
Assignees
Labels
type:bug Something isn't working

Comments

@jonathanolson
Copy link
Contributor

(Hard, this is the bug I was describing with the circular clipping where we're getting a mismatch of edges).

It seems like EdgedFace.getBinaryCircularClip is outputting invalid data. As discussed, later stages need the start/end points of edges to match up precisely. I probably screwed up something like this in CircularClipping.binaryCircularClipEdges.

To reproduce, apply the patch below (or just... enable the one test in RasterizeTests.ts), and run the unit tests.

Subject: [PATCH] Enable test
---
Index: js/raster/RasterizeTests.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/raster/RasterizeTests.ts b/js/raster/RasterizeTests.ts
--- a/js/raster/RasterizeTests.ts	(revision 5e56f9c48be2d1fe4b67f2f93ce2980a7d1f4e8d)
+++ b/js/raster/RasterizeTests.ts	(date 1697254991298)
@@ -14,7 +14,7 @@
 
 QUnit.module( 'Rasterize' );
 
-QUnit.skip( 'split clip start end matches', assert => {
+QUnit.test( 'split clip start end matches', assert => {
 
   const colors = _.range( 0, 100 ).map( i => new RenderColor( new Vector4( i / 100, 0, 0, 1 ) ) );
   const outputSize = 768 * 2;
@jonathanolson jonathanolson added the type:bug Something isn't working label Oct 14, 2023
@jonathanolson
Copy link
Contributor Author

I believe the other two circular clip tests that are skipped are likely to be the same issue. If the area is off... I might have a bigger bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants