Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ?shuffleListeners #170

Closed
zepumph opened this issue May 29, 2020 · 3 comments
Closed

support ?shuffleListeners #170

zepumph opened this issue May 29, 2020 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented May 29, 2020

From phetsims/axon#215, when running with ?shuffleListeners, we get this error: assigning to responsible dev to determine if it is worth fixing:

acid-base-solutions
Uncaught Error: Assertion failed: reentry detected, value=0.11766065182659499, oldValue=0.11766065182659496
Error: Assertion failed: reentry detected, value=0.11766065182659499, oldValue=0.11766065182659496
    at window.assertions.assertFunction (http://localhost:8080/assert/js/assert.js:22:13)
    at NumberProperty._notifyListeners (http://localhost:8080/axon/js/Property.js:270:15)
    at NumberProperty.set (http://localhost:8080/axon/js/Property.js:171:14)
    at http://localhost:8080/acid-base-solutions/js/mysolution/model/MySolutionModel.js:87:72
    at TinyEmitter.emit (http://localhost:8080/axon/js/TinyEmitter.js:69:53)
    at NumberProperty._notifyListeners (http://localhost:8080/axon/js/Property.js:273:25)
    at NumberProperty.set (http://localhost:8080/axon/js/Property.js:171:14)
    at http://localhost:8080/acid-base-solutions/js/mysolution/view/StrengthSlider.js:82:26
    at TinyEmitter.emit (http://localhost:8080/axon/js/TinyEmitter.js:69:53)
    at NumberProperty._notifyListeners (http://localhost:8080/axon/js/Property.js:273:25)
@pixelzoom
Copy link
Contributor

To be considered when a new release branch is created for this sim. And my feeling is that this is incredibly low priority, and would not block a release.

@pixelzoom
Copy link
Contributor

In phetsims/axon#215, @zepumph added a "shuffleListeners" test to CT. This sim is not opting out, and has not added hasListenerOrderDependencies: true to anything sim specific. So I suspect that this issue no longer exists for this sim. I'll self assign to watch CT. If this doesn't occur in a few more cycles, I'll close this issue.

@pixelzoom
Copy link
Contributor

I suspect that this didn't have anything to do with "shuffleListeners" and is instead related to reentrant Properties. In d9d3e8f, @samreid added reentrant: true to a number of Properties for phetsims/axon#179, including Properties in MySolutionModel.ts (which appears in the above stack trace.) Since we try to avoid using reentrant: true, that should be investigated - tracking in #188.

Closing this issue, since "shuffleListeners" test is passing in CT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants