You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From phetsims/axon#215, when running with ?shuffleListeners, we get this error: assigning to responsible dev to determine if it is worth fixing:
acid-base-solutions
Uncaught Error: Assertion failed: reentry detected, value=0.11766065182659499, oldValue=0.11766065182659496
Error: Assertion failed: reentry detected, value=0.11766065182659499, oldValue=0.11766065182659496
at window.assertions.assertFunction (http://localhost:8080/assert/js/assert.js:22:13)
at NumberProperty._notifyListeners (http://localhost:8080/axon/js/Property.js:270:15)
at NumberProperty.set (http://localhost:8080/axon/js/Property.js:171:14)
at http://localhost:8080/acid-base-solutions/js/mysolution/model/MySolutionModel.js:87:72
at TinyEmitter.emit (http://localhost:8080/axon/js/TinyEmitter.js:69:53)
at NumberProperty._notifyListeners (http://localhost:8080/axon/js/Property.js:273:25)
at NumberProperty.set (http://localhost:8080/axon/js/Property.js:171:14)
at http://localhost:8080/acid-base-solutions/js/mysolution/view/StrengthSlider.js:82:26
at TinyEmitter.emit (http://localhost:8080/axon/js/TinyEmitter.js:69:53)
at NumberProperty._notifyListeners (http://localhost:8080/axon/js/Property.js:273:25)
The text was updated successfully, but these errors were encountered:
To be considered when a new release branch is created for this sim. And my feeling is that this is incredibly low priority, and would not block a release.
In phetsims/axon#215, @zepumph added a "shuffleListeners" test to CT. This sim is not opting out, and has not added hasListenerOrderDependencies: true to anything sim specific. So I suspect that this issue no longer exists for this sim. I'll self assign to watch CT. If this doesn't occur in a few more cycles, I'll close this issue.
I suspect that this didn't have anything to do with "shuffleListeners" and is instead related to reentrant Properties. In d9d3e8f, @samreid added reentrant: true to a number of Properties for phetsims/axon#179, including Properties in MySolutionModel.ts (which appears in the above stack trace.) Since we try to avoid using reentrant: true, that should be investigated - tracking in #188.
Closing this issue, since "shuffleListeners" test is passing in CT.
From phetsims/axon#215, when running with ?shuffleListeners, we get this error: assigning to responsible dev to determine if it is worth fixing:
The text was updated successfully, but these errors were encountered: