Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Design for combo box #73

Closed
jessegreenberg opened this issue Jan 5, 2018 · 6 comments
Closed

Visual Design for combo box #73

jessegreenberg opened this issue Jan 5, 2018 · 6 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

From #64, this issue will collect thoughts for single design. #64 has grown quite a bit, and we would like to keep that specific to the HTML impelemntation while this issue will be for visual mockups.

@jessegreenberg will move some of the images and summarize thoughts from that issue.

@jessegreenberg jessegreenberg self-assigned this Jan 5, 2018
@jessegreenberg
Copy link
Contributor Author

Notes from 1/30/18 meeting:

@terracoda said we don't need the outer focus on the list.

@jessegreenberg
Copy link
Contributor Author

@terracoda also wondered if we needed a different visual indicator to distinguish between what is focused and what is selected when navigating the menu with arrow keys.

@jessegreenberg
Copy link
Contributor Author

Removing my assignment since this is about visual design. @emily-phet can you please sort this issue?

@terracoda terracoda self-assigned this Feb 2, 2018
@terracoda
Copy link
Contributor

terracoda commented Feb 8, 2018

Copying notes from #64
Things to consider for the issue about Visual Design

Our list box currently has no visual difference between the focused item in the list and the selected item in the list.

@terracoda
Copy link
Contributor

@jessegreenberg, I can move the necessary visuals from issue #64, so leave that to me.

@terracoda
Copy link
Contributor

I don't think we are exploring this further at this time, so closing for now.
We have an accessible combobox in phetsims/molarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants