Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

Consider adding a ClassInstance accessor for inferred_types #44

Open
cmungall opened this issue Apr 1, 2016 · 2 comments
Open

Consider adding a ClassInstance accessor for inferred_types #44

cmungall opened this issue Apr 1, 2016 · 2 comments

Comments

@cmungall
Copy link
Member

cmungall commented Apr 1, 2016

The current ClassInstance.types variable is intended for direct types.

We could add an optional inferred_types field that stores the superclasses and equivalence classes. This is useful in architectures where the query engine is ontology-unaware (e.g. most DBMSs). An ontology-aware processor (e.g. part of phenotools) could take a packet P, populate the inferred_types to produce P*. The database engine then loads P* and is able to efficiently return valid and complete phenotype query results.

@julesjacobsen
Copy link
Contributor

Would this only be used in the API, but not exposed in the YAML/JSON?

@balhoff
Copy link
Member

balhoff commented May 17, 2016

I am guessing do expose in the YAML/JSON. Someone can use an ontology-aware tool such as pxftools to populate the inferred_types fields, and then pass the file to another system that can read phenopacket files but doesn't have ontology capabilities.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants