From fa974748bae176e8b1dd286d0275b0be1ad59515 Mon Sep 17 00:00:00 2001 From: AlexisCnockaert Date: Mon, 18 Nov 2024 10:00:44 +0100 Subject: [PATCH 1/2] Branch: CommandRepoBrowser1841, Fixes # 1841 --- Iceberg-TipUI/IceTipDiffPanel.class.st | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Iceberg-TipUI/IceTipDiffPanel.class.st b/Iceberg-TipUI/IceTipDiffPanel.class.st index 6230eb5f95..7eb01e09be 100644 --- a/Iceberg-TipUI/IceTipDiffPanel.class.st +++ b/Iceberg-TipUI/IceTipDiffPanel.class.st @@ -8,9 +8,8 @@ also #elements answer should be a collection of elements that also understand el " Class { #name : 'IceTipDiffPanel', - #superclass : 'IceTipPresenter', + #superclass : 'IceTipBrowser', #instVars : [ - 'model', 'diffPanel', 'iceNodesTree' ], @@ -19,6 +18,20 @@ Class { #tag : 'View-Branch' } +{ #category : 'commands' } +IceTipDiffPanel class >> buildGeneralCommandGroupWith: presenter for: aCommandGroup [ + + "Nothing to add" +] + +{ #category : 'commands' } +IceTipDiffPanel class >> buildSelectionCommandGroupWith: presenter for: aCommandGroup [ + { + IceTipBrowseCommand. + IceTipInspectCommand } do: [ :each | + aCommandGroup register: (each forSpecContext: presenter)] +] + { #category : 'instance creation' } IceTipDiffPanel class >> onDiff: aDiff [ @@ -204,6 +217,12 @@ IceTipDiffPanel >> leftLabel: aString [ diffPanel leftLabel: aString. ] +{ #category : 'accessing - ui' } +IceTipDiffPanel >> mainList [ + +^iceNodesTree +] + { #category : 'accessing' } IceTipDiffPanel >> model [ From 96aca2b594ab0714de5693f2af4ffbefd72fa3a6 Mon Sep 17 00:00:00 2001 From: AlexisCnockaert Date: Mon, 18 Nov 2024 16:30:52 +0100 Subject: [PATCH 2/2] removed extra commands --- Iceberg-TipUI/IceTipDiffPanel.class.st | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Iceberg-TipUI/IceTipDiffPanel.class.st b/Iceberg-TipUI/IceTipDiffPanel.class.st index 7eb01e09be..3a72a20929 100644 --- a/Iceberg-TipUI/IceTipDiffPanel.class.st +++ b/Iceberg-TipUI/IceTipDiffPanel.class.st @@ -18,6 +18,17 @@ Class { #tag : 'View-Branch' } +{ #category : 'commands' } +IceTipDiffPanel class >> buildCommandsGroupWith: presenter forRoot: aCommandGroup [ + | selectionCommandGroup | + selectionCommandGroup := (CmCommandGroup named: self selectionCommandGroupName) asSpecGroup. + + aCommandGroup register: selectionCommandGroup. + + self buildSelectionCommandGroupWith: presenter for: selectionCommandGroup. + +] + { #category : 'commands' } IceTipDiffPanel class >> buildGeneralCommandGroupWith: presenter for: aCommandGroup [