Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IceProxyMCVersionInfo>>#gtDisplayString should be removed #1468

Closed
MarcusDenker opened this issue Apr 1, 2021 · 2 comments · Fixed by #1524
Closed

IceProxyMCVersionInfo>>#gtDisplayString should be removed #1468

MarcusDenker opened this issue Apr 1, 2021 · 2 comments · Fixed by #1524
Milestone

Comments

@MarcusDenker
Copy link
Contributor

gtDisplayString has no senders anymore and has a deprecation rewrite on the level of Object

--> it can be removed

@tinchodias
Copy link
Collaborator

I was going to only push a commit removing this method but after browsing the code of that class, I preferred to comment other removal candidates in the same class:

  • gtDisplayOn:
  • asSpotterCandidateLink

Should we just remove them or there are candidate names for renaming? I mean, for the new inspector / new spotter.

@Ducasse
Copy link
Collaborator

Ducasse commented Apr 5, 2021

Martin normally I migrated all the gtDisplayOn: to displayStringOn:
I should remove all the gtDisplay:.
there should be no reference to gtDisplayOn: (in my PR there were none). Now may be spec got merged and some of my changes got reverted. I do not know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants