Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix P9's #testExternalIDEDependencies #1406

Closed
tinchodias opened this issue Feb 2, 2021 · 3 comments
Closed

Fix P9's #testExternalIDEDependencies #1406

tinchodias opened this issue Feb 2, 2021 · 3 comments

Comments

@tinchodias
Copy link
Collaborator

The PR to merge into Pharo 9.0 showed some tests failures.
One of them is testExternalIDEDependencies which detects that a dependency to Ring-Core is introduced by v2.

@tinchodias
Copy link
Collaborator Author

I've checked that this test does pass in current P9.

I checked also in my P9 with Iceberg v2 loaded to debug.
In the context of the failing test, I evaluated:

	packages select: [ :aPackage |
		| deps externalDeps | 
		deps := self dependenciesReport dependenciesOf: aPackage.
		externalDeps := deps copyWithoutAll: packages.
		externalDeps notEmpty ].

The only element is Iceberg-Plugin-Calypso... the reason is that I moved 3 commands from Calypso-SystemPlugins-Monticello-Browser to this new Iceberg package.

I can put back those 3 commands to the original Calypso-SystemPlugins-Monticello-Browser package to keep the test green.

@tinchodias
Copy link
Collaborator Author

Should be fixed in 2447358

@tinchodias
Copy link
Collaborator Author

This wasn't fixed. I hope 8d34df5 finally achieves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant