Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings to pass testDefaultImageDoesNotStoreAnySetting ? #1405

Closed
tinchodias opened this issue Feb 2, 2021 · 5 comments
Closed

Fix settings to pass testDefaultImageDoesNotStoreAnySetting ? #1405

tinchodias opened this issue Feb 2, 2021 · 5 comments

Comments

@tinchodias
Copy link
Collaborator

The PR to merge into Pharo 9.0 showed some tests failures.
One of them is testDefaultImageDoesNotStoreAnySetting, which I don't understand well, but finds that the following settings have something wrong:

a StoredSetting('#useCustomSsh#username')
a StoredSetting('#useCustomSsh#keyPassphrase')
a StoredSetting('#commitPreferences#saveImageOnCommit')
a StoredSetting('#commitPreferences#pushOnCommit'))

This seems to be showstopper to proceed to merge v2 so must be fixed with priority.

@tinchodias
Copy link
Collaborator Author

I just checked that the first 2 settings already make this test fail in P9.0.

By contrary, the last two are added by v2.

@tesonep
Copy link
Collaborator

tesonep commented Feb 4, 2021

@tinchodias does the settings have default values? Are the default values the same set "by default" by the initialization.
The idea of the test is to guarantee that a clean image does not save settings when you save settings (there all defaults, and only the non-defaults are saved).

@tesonep
Copy link
Collaborator

tesonep commented Feb 4, 2021

@tinchodias ping me and we check it together if you wish

@tinchodias
Copy link
Collaborator Author

Maybe these settings should be stored in the credentials store. I can ping you later.

@tinchodias
Copy link
Collaborator Author

We connected and fixed it, in dev-2.0

e734664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants