-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings to pass testDefaultImageDoesNotStoreAnySetting ? #1405
Comments
I just checked that the first 2 settings already make this test fail in P9.0. By contrary, the last two are added by v2. |
@tinchodias does the settings have default values? Are the default values the same set "by default" by the initialization. |
@tinchodias ping me and we check it together if you wish |
Maybe these settings should be stored in the credentials store. I can ping you later. |
We connected and fixed it, in dev-2.0 |
The PR to merge into Pharo 9.0 showed some tests failures.
One of them is
testDefaultImageDoesNotStoreAnySetting
, which I don't understand well, but finds that the following settings have something wrong:This seems to be showstopper to proceed to merge v2 so must be fixed with priority.
The text was updated successfully, but these errors were encountered: