Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing the history button in calypso on libgit1.0 VM P9 latest crashes #1377

Closed
Ducasse opened this issue Jun 18, 2020 · 2 comments
Closed

Comments

@Ducasse
Copy link
Collaborator

Ducasse commented Jun 18, 2020

crash.txt

@Ducasse
Copy link
Collaborator Author

Ducasse commented Jun 18, 2020

ExternalAddress
    0x7ffee5841b08 M LGitDiff>diff_tree_to_tree:repo:old_tree:new_tree:opts: 0x11466cf10: a(n) LGitDiff
    0x7ffee5841b78 M [] in LGitDiff>diffTree:toTree:options: 0x11466cf10: a(n) LGitDiff
    0x7ffee5841ba8 M LGitDiff(LGitExternalObject)>withReturnHandlerDo: 0x11466cf10: a(n) LGitDiff
    0x7ffee5841be0 M LGitDiff>diffTree:toTree:options: 0x11466cf10: a(n) LGitDiff
    0x7ffee5841c30 M LGitTree>diffTo:options: 0x113dc3230: a(n) LGitTree
    0x7ffee5841c98 M [] in IceLibgitTonelLog>collectCommitsFor:path: 0x113dc20c8: a(n) IceLibgitTonelLog

@guillep
Copy link
Member

guillep commented Jun 18, 2020

@Ducasse could you try applying the changes in this commit and retest: 8d2fa26 ?

With that change I cannot reproduce that problem anymore. But further testing is always appretiated.
That change is part of release 1.8.3 https://github.com/pharo-vcs/iceberg/releases/tag/v1.8.3, which is proposed for integration in Pharo9 in here: pharo-project/pharo#6628

@Ducasse Ducasse closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants