From dbb753b5defba4726e60b891f447db8ac5678696 Mon Sep 17 00:00:00 2001 From: CyrilFerlicot Date: Tue, 21 Nov 2023 21:19:16 +0100 Subject: [PATCH] Avoid useless garbage collects Some garbage collects seems useless in Iceberg tests (I ran the tests multiple times without troubles) and are slowing down Iceberg tests --- Iceberg-Tests/IceGitTestFactory.class.st | 3 +-- Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Iceberg-Tests/IceGitTestFactory.class.st b/Iceberg-Tests/IceGitTestFactory.class.st index d7af8c424d..016429626a 100644 --- a/Iceberg-Tests/IceGitTestFactory.class.st +++ b/Iceberg-Tests/IceGitTestFactory.class.st @@ -106,10 +106,9 @@ IceGitTestFactory >> remoteFileUrl [ { #category : 'initialization' } IceGitTestFactory >> tearDownWithRepository: aRepository [ - + aRepository ifNotNil: [ aRepository free. - Smalltalk garbageCollect. aRepository location ifNotNil: #ensureDeleteAll ]. self remoteFileUrl asFileReference ensureDeleteAll ] diff --git a/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st b/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st index 744e62fc7e..43bd0bf752 100644 --- a/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st +++ b/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st @@ -110,6 +110,5 @@ IceNotYetClonedRepositoryFixture >> setUp [ { #category : 'running' } IceNotYetClonedRepositoryFixture >> tearDown [ - Smalltalk garbageCollect. - self location ifNotNil: #ensureDeleteAll. + self location ifNotNil: #ensureDeleteAll ]