Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused Ivars in Iceberag: IceTipAdoptCommitCommand , LGitReadStream #8423

Closed
MarcusDenker opened this issue Jan 26, 2021 · 3 comments · Fixed by #8461
Closed

unused Ivars in Iceberag: IceTipAdoptCommitCommand , LGitReadStream #8423

MarcusDenker opened this issue Jan 26, 2021 · 3 comments · Fixed by #8461
Assignees
@tinchodias
Labels
Type: Cleanup

Comments

@MarcusDenker
Copy link
Member

Describe the problem
LGitReadStream and IceTipAdoptCommitCommand have unused instance variables
@MarcusDenker
Copy link
Member Author

MCGitRemoteRepository

@MarcusDenker
Copy link
Member Author

Fixing this is a step for issue #8189

@tinchodias
Copy link
Contributor

In short: This will be fixed when #8461 is merged.

Details:

IceTipAdoptCommitCommand was already fixed in Iceberg v2, but the unused ivar in LGitReadStream still was there.

However, there was a recent PR from @astares that fixes it. I created the new version 2.1.2 including such PR. It is now used from Iceberg v2.

@MarcusDenker MarcusDenker linked a pull request Feb 4, 2021 that will close this issue
Move to Iceberg v2 #8461
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinchodias tinchodias

Labels
Type: Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to Iceberg v2 tinchodias/pharo
2 participants
@MarcusDenker @tinchodias