Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reverting all changes to class in Iceberg commit window #14395

Closed
daniels220 opened this issue Jul 31, 2023 · 0 comments · Fixed by pharo-vcs/iceberg#1793
Closed

Error reverting all changes to class in Iceberg commit window #14395

daniels220 opened this issue Jul 31, 2023 · 0 comments · Fixed by pharo-vcs/iceberg#1793

Comments

@daniels220
Copy link
Contributor

Bug description
If I have several changes to extension methods of a class, and try to revert all
'IceWorkingCopyPatcherVisitor does not understand #visitExtensionDefinition:'

To Reproduce
Steps to reproduce the behavior:

  1. Make several changes to extension methods of the same class, in the same package.
  2. Open a commit browser for the repo containing that package. The method changes are grouped under a single tree node for the class.
  3. Right-click the class and choose Revert
  4. See IceWorkingCopyPatcherVisitor does not understand #visitExtensionDefinition: error

Expected behavior
Revert all changes to extension methods in that class for that package (the nodes under it in the tree).

Version information:

  • OS: Windows/any
  • Pharo Version 11

Expected development cost
I imagine the solution is implementing the method in question and shouldn't be too difficult. I'm not familiar with Iceberg, so I'm probably not the best person to do this, but if it annoys me enough I might try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant