Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show folder button is broken in Windows 10 #551

Closed
fuhrmanator opened this issue Apr 15, 2022 · 1 comment
Closed

Show folder button is broken in Windows 10 #551

fuhrmanator opened this issue Apr 15, 2022 · 1 comment
Labels

Comments

@fuhrmanator
Copy link
Contributor

Describe the bug
Clicking on the Show folder button for an image fails in PL 3.0 - this is a very useful feature in Windows but it now throws a Instance of Win64Platform did not understand #privShellExplore: error.

To Reproduce
Steps to reproduce the behavior:

  1. Running PL in Windows 10, Select an image
  2. Click on the Show (folder) button (icon):
    image
  3. See error

Expected behavior
Show the folder of the image in the OS (this feature worked fine in PL 2.x, it's a regression)

Screenshots
image

Version information:

  • OS: Windows 10
  • Version: Pharo Launcher 3.0

Expected development cost
Unknown, but regressions with different OS could be tested in CI. Windows is a popular platform with end users, even if the devs prefer Linux and MacOS.

@demarey
Copy link
Contributor

demarey commented Apr 26, 2022

@fuhrmanator this kind of feature is very hard to test => interaction with the operating system.
The only thing that could be tested is that there is no error on instance side. It is done in a command test but tests are, for now, only ran on linux. Only a few tests are impacted by the OS and I'm not sure it worths to run tests on all OS/arch combinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants