Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryLogger could be reorganised #11

Open
Ducasse opened this issue Sep 13, 2019 · 3 comments
Open

MemoryLogger could be reorganised #11

Ducasse opened this issue Sep 13, 2019 · 3 comments

Comments

@Ducasse
Copy link
Member

Ducasse commented Sep 13, 2019

Hi alistair

I would like to change the logic of the memory logger.
Do you think that it would be possible to have a version without the startAutoSaving?
Do you think that we could also have one version without the dependency to UFFI?

@girba
Copy link
Contributor

girba commented Sep 13, 2019

I think we could try to model startAutoSaving as a logger decorator.

I am not sure I understand what you mean by the dependency to UFFI. Where do you see this one?

@Ducasse
Copy link
Member Author

Ducasse commented Sep 13, 2019

This is interesting to try.
You have a reference to LibC to get a current process id as the filename.

@girba
Copy link
Contributor

girba commented Sep 13, 2019

Oh, I see now. Yes, we will give the decorator approach a try next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants