Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Adding characters to PGGTokenizer for supporting starting Spanish punctuation signs #28

Open
offray opened this issue Sep 11, 2023 · 0 comments

Comments

@offray
Copy link

offray commented Sep 11, 2023

In PGTokenizer>>sentenceTokenize: the line that says:

(( cur = $? or: cur = $!) or: (cur = $. and: streamPointer peek = $ ))

should be replaced by:

((#($? $! $¿ $¡) includes: cur) or: (cur = $. and: streamPointer peek = $ ))

so it can support Spanish starting punctuation signs (and not only English ones).

@olekscode @nikhilpinnaparaju: as I'm working with Polyglot, confirming bug fixes, reporting new fixes, like this one or even writing new documentation and new tutorials using Polyglot, I wonder if there is a particular contribution guidelines that I should follow for this repository or if just do a pull request and that's it.

Thanks,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant