Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated benchmark testing #18

Open
conradtchan opened this issue Feb 18, 2022 · 1 comment
Open

Automated benchmark testing #18

conradtchan opened this issue Feb 18, 2022 · 1 comment

Comments

@conradtchan
Copy link
Contributor

The benchmarks are not currently tested until they are run in the main Phantom repo. This can cause test failures that are only caught very late in the testing process.

For example, #12 was merged before it was ready, causing this test failure for an unrelated commit on the main Phantom repo.

Checking if the benchmark passes with a workflow in this repo will reduce the likelihood of this issue.

@danieljprice
Copy link
Contributor

this is a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants