Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] create python decorator for get approval #12

Open
edwinkys opened this issue Nov 2, 2024 · 0 comments · May be fixed by #25
Open

[FEAT] create python decorator for get approval #12

edwinkys opened this issue Nov 2, 2024 · 0 comments · May be fixed by #25
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@edwinkys
Copy link
Contributor

edwinkys commented Nov 2, 2024

Feature Description

We want to add a Python decorator abstracting the core functionality of get approval method:

  • @phantasm.require_approval()
  • @phantasm.require_approval_with_parameters()

Potential Solution

require_approval() should only care if the function is approved or not.
require_approval_with_parameters() should support inserting parameters from the approvers.

Additional Context

I want the usage to be similar with this from HumanLayer

@edwinkys edwinkys added enhancement New feature or request good first issue Good for newcomers labels Nov 2, 2024
@edwinkys edwinkys self-assigned this Nov 23, 2024
@edwinkys edwinkys linked a pull request Nov 23, 2024 that will close this issue
5 tasks
@edwinkys edwinkys linked a pull request Nov 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant