Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect transition between issue and milestone activities #71

Closed
UEvgeniy opened this issue Jan 20, 2018 · 1 comment · Fixed by #79
Closed

Incorrect transition between issue and milestone activities #71

UEvgeniy opened this issue Jan 20, 2018 · 1 comment · Fixed by #79
Assignees
Labels

Comments

@UEvgeniy
Copy link
Collaborator

UEvgeniy commented Jan 20, 2018

  1. open repo
  2. open milestones list
  3. select milestone with opened issues
  4. select any issue.
  5. clicking on back button (arrow to the left on screen) redirects to repository activity with tabs instead of milestone view. Clicking on touch button on smartphone redirects correctly.
@phansier
Copy link
Owner

Due to comment of Jonan jonan#343 (comment) this back button is "up" button and should always lead not to the previous screen, but to the up screen (repositories, as it was before).
Need to revert changes in https://github.com/AndreySBer/ForkHub/tree/pr_comments_fix

@phansier phansier reopened this Feb 27, 2018
@phansier phansier closed this as completed Mar 5, 2018
@phansier phansier assigned phansier and unassigned Motoaleks Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants