Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: return value of view::getVar() is not specified #16276

Closed
s-ohnishi opened this issue Jan 31, 2023 · 3 comments · Fixed by #16379
Closed

[BUG]: return value of view::getVar() is not specified #16276

s-ohnishi opened this issue Jan 31, 2023 · 3 comments · Fixed by #16379
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@s-ohnishi
Copy link

Describe the bug
Since the return value of View::getVar() is not specified, it is not reflected in ide-stubs and an error is displayed in the IDE.
View::getVar()

Screenshots
getVar

Details

  • Phalcon version: 5.1.3
  • PHP Version: 8.1.14
  • Operating System: Debian 10.13
  • Installation type: PECL, composer(for phalcon/ide-stubs)
  • Zephir version (if any):
  • Server: Nginx 1.22.1
@s-ohnishi s-ohnishi added bug A bug report status: unverified Unverified labels Jan 31, 2023
@sinbadxiii
Copy link
Contributor

@s-ohnishi Can you show function getVar() from vendor/phalcon/ide-staubs/src/Mvc/View.php?

@s-ohnishi
Copy link
Author

of course.
This is how it looks in my current environment (phalcon/ide-stubs 5.1.0).

    /**
     * Returns a parameter previously set in the view
     *
     * @param string $key
     */
    public function getVar(string $key)
    {
    }

The latest on git is the same
https://github.com/phalcon/ide-stubs/blob/master/src/Mvc/View.php#L486

@niden niden linked a pull request Jul 19, 2023 that will close this issue
5 tasks
@niden niden self-assigned this Jul 19, 2023
@niden niden added this to Phalcon v5 Jul 19, 2023
@niden niden moved this to In Progress in Phalcon v5 Jul 19, 2023
@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Jul 19, 2023
@niden
Copy link
Member

niden commented Jul 20, 2023

Resolved in #16379

Thank you @s-ohnishi

@niden niden closed this as completed Jul 20, 2023
@niden niden moved this from In Progress to Implemented in Phalcon v5 Jul 20, 2023
@niden niden moved this from Implemented to Released in Phalcon v5 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

3 participants