Consider lowercase sslmode for easier JDBC URL adaption

[nhajratw]

Bug Report

Migrating from jdbc to r2dbc is confusing due to the jdbc parameter of sslmode and r2dbc requiring it to be cased differently as sslMode -- Ideally they should be the same, but at a minimum, i'd suggest a warning during URL parsing to indicate that the case differs.

Current Behavior

parameter sslmode does not work.

parameter sslMode works.

[mp911de]

Parameter compatibility with JDBC was never a goal. However, this seems a small change to additionally consider lowercase sslmode. Feel free to submit a pull request, see

r2dbc-postgresql/src/main/java/io/r2dbc/postgresql/PostgresqlConnectionFactoryProvider.java

Line 181 in 40c2be0

public static final Option<SSLMode> SSL_MODE = Option.valueOf("sslMode");

.

[govi20]

@mp911de this change won't be backward compatible. shouldn't it be part of a major version release right?

[mp911de]

It should be. The approach is to introduce another constant and check it as fallback instead of replacing the existing constant for the option name.