Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include site_id query param in all actions #736

Open
fitzgerald opened this issue Nov 8, 2023 · 1 comment
Open

Include site_id query param in all actions #736

fitzgerald opened this issue Nov 8, 2023 · 1 comment
Assignees

Comments

@fitzgerald
Copy link
Member

When using multisite, users can do some actions (like 'cancel') that redirects to the root of the admin site (/admin/pages). If the site_id query param is not included, they are not authorized to view the root. This forces a logout.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure caching is disabled
  2. Go to a page in the admin section that is not a child of the root (I could repro this best by selecting a page from all productions.
  3. Hit 'cancel' (which redirects to root with no site_id)
  4. Select a page to edit
  5. Hit 'save changes'
  6. This sometimes redirects the user to /admin/pages with no site_id, which pushed them to the login screen

Expected behavior
Ideally, we would include the site_id in any link to /admin/pages

Additional context
I don't know why, but this seemed to happen more often when I was using the www version of the site than the non-www.

@danigirl329
Copy link
Member

danigirl329 commented Nov 13, 2023

It looks like if the user is switching around somewhere along the lines if there is no query param and no session[:site_id] of the site it is failing to lookup the site and then logging the user out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants