-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bbox library #714
bbox library #714
Conversation
…dimension too large erros
…in rare cases the bounding box can be wrong. this happens when the curve is merely back and forth, i.e. the quadratic equation becomes almost linear but the linear coefficient is something of the form 0/0. I am not an expert in TeX regularization, but there should be some means. On the other hand, implementing it will most likely really lead to performance issues.
This needs quite a bit of work. I'll see whether I can do something over the weekend. |
A manual for git can be found on https://git-scm.com/ |
Hi Henri,
I agree that at this stage this is merely a proof of principle, and I did
not mean to dump that on you. If you give me a pointer to some similar code
from which I could infer which structures you prefer, I will be happy to
give it a shot.
…On Fri, Jul 19, 2019 at 12:47 PM Henri Menke ***@***.***> wrote:
This needs quite a bit of work. I'll see whether I can do something over
the weekend.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#714?email_source=notifications&email_token=AISROXF5UWGBH7ELUWAQNW3QAGLTRA5CNFSM4IFC4T72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2LJF6Y#issuecomment-513184507>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AISROXHOU7MNLRI6WKBMBLLQAGLTRANCNFSM4IFC4T7Q>
.
|
6d4a25c
to
0517551
Compare
\tikzset{reuse path/.code={% | ||
\pgfsyssoftpath@setcurrentpath{#1}} | ||
}% unfortunately this is *not* the definition of the `use path` key that has | ||
% been added to the pgfmanual! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm... What's the fundamental difference here?
\tikzoption{use path}{\tikz@addmode{\pgfsyssoftpath@setcurrentpath#1}}% |
current reverse clip'/.style={insert path={{% https://tex.stackexchange.com/a/127045 | ||
(current bounding box.south east) -| | ||
(current bounding box.north west) -| cycle | ||
}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current reverse clip
and current reverse clip'
are the same thing or am I missing something?
}}}, | ||
even odd clip/.code={% https://tex.stackexchange.com/a/76216 | ||
\pgfseteorule}} | ||
\tikzset{Venn diagram/.style={/utils/exec=\tikzset{venn/.cd,#1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just Venn diagram/.style={venn/.cd,#1}
?
execute at begin scope={ | ||
\pgfmathtruncatemacro{\pgfutil@tmpD}{dim(\pgfkeysvalueof{/tikz/venn/labels})} | ||
\ifnum\pgfutil@tmpD<\pgfkeysvalueof{/tikz/venn/number of sets} | ||
\tikzerror{Less labels then Venn sets.}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Fewer labels than Venn sets.”
yshift=-\pgfkeysvalueof{/tikz/venn/frame margin}]Venn Box.south west) | ||
rectangle ([xshift=\pgfkeysvalueof{/tikz/venn/frame margin}, | ||
yshift=\pgfkeysvalueof{/tikz/venn/frame margin}]Venn Box.north east); | ||
},on background layer}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this where the enormous execute at begin scope
ends? I can't really see for the lack of indentation. Also when doing this you have to somehow make sure that Venn diagram
can only be used as a scope or picture option.
@@ -0,0 +1,50 @@ | |||
\documentclass{article} | |||
\usepackage{tikz} | |||
\usepackage{tikz-3dplot} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evidently this library is meant for interop with tikz-3dplot
, which is why I won't merge this into mainline PGF/TikZ. I'm not convinced by having more user macros. I'm also not convinced by \pgfmathtdparse
. That seems very fragile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In response to #731 (comment) which was probably meant to appear here:
The 3dtools library introduces a whole bunch of new user macros, like \pgfmathtdparse
, \pgfmathprintvector
, \tdparse
(is that the same as \pgfmathtdparse
?) and \orthmat
(is this meant for users? If not, why is it public?). This somewhat collides with the PGF/TikZ philosophy of using keys and values instead of commands.
Right now, the whole 3dtools library is in a single file tikzlibrary3dtools.code.tex
. It uses the LaTeX package calculator
and \newcommand
, i.e. it cannot be used with other formats. Also it defines macros with \pgf...
prefix which clearly belong in a PGF rather than a TikZ library.
Last but not least, I am totally not stopping you from publishing this library independently on CTAN for use with TikZ, just like tikz-cd
or tikz-feynman
. So while I can understand your disappointment that this is probably not going to be in mainline without some vast improvement, I am slightly confused by the accusation of “destroying hours of work”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have packaged up tikz-3dtools
and put it here: https://github.com/pgf-tikz/tikz-3dtools
Release v1.0 is also submitted to CTAN already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tikz-3dtools
has appeared on CTAN and should be in TeX Live soon.
https://ctan.org/pkg/tikz-3dtools
@@ -0,0 +1,161 @@ | |||
\tikzset{% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some refactoring I have merged the bbox
library into PGF/TikZ. Thank you for your contribution.
@@ -0,0 +1,174 @@ | |||
% Copyright 2019 by an anonymous marmot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to merge the venn
library, but the code is lacking in some places. Would it also be possible to make it a PGF library rather than a pure TikZ library?
For some reason 3dtools is on CTAN
https://ctan.org/pkg/tikz-3dtools
All I can say is that I did not upload it, nor do I think it is in a stage
that allows it to be published. That is, I do not feel responsible for
complications.
…On Wed, Nov 13, 2019 at 2:15 PM Henri Menke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In experiments/Marmot/3dtools/3dtoolstest.tex
<#714 (comment)>:
> @@ -0,0 +1,50 @@
+\documentclass{article}
+\usepackage{tikz}
+\usepackage{tikz-3dplot}
In response to #731 (comment)
<#731 (comment)> which
was probably meant to appear here:
------------------------------
The 3dtools library introduces a whole bunch of new user macros, like
\pgfmathtdparse, \pgfmathprintvector, \tdparse (is that the same as
\pgfmathtdparse?) and \orthmat (is this meant for users? If not, why is
it public?). This somewhat collides with the PGF/Ti*k*Z philosophy of
using keys and values instead of commands.
Right now, the whole 3dtools library is in a single file
tikzlibrary3dtools.code.tex. It uses the LaTeX package calculator and
\newcommand, i.e. it cannot be used with other formats. Also it defines
macros with \pgf... prefix which clearly belong in a PGF rather than a Ti
*k*Z library.
Last but not least, I am totally not stopping your from publishing this
library independently on CTAN for use with Ti*k*Z, just like tikz-cd or
tikz-feynman. So while I can understand your disappointment that this is
probably not going to be in mainline without some vast improvement, I am
slightly confused by the accusation of “destroying hours of work”.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#714?email_source=notifications&email_token=AISROXBNIGMYQMWJOAMCADDQTR36TA5CNFSM4IFC4T72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLPNVSY#discussion_r346031556>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISROXBBO23KQ4VZA22M6WTQTR36TANCNFSM4IFC4T7Q>
.
|
I'm getting more and more confused. In #731 (comment) you seemed very worried about all the work you put into |
Whether or not the work in 3dtools is in vain will depend on whether or not
`\csname tikz@dcl@coord@#1\endcsname` will still work in the future. My
only concern was that it might get removed. It was not my concern that it
is not published. It should be only published if it is significantly more
advanced.
…On Sat, Nov 16, 2019 at 10:06 PM Henri Menke ***@***.***> wrote:
I'm getting more and more confused. In #731 (comment)
<#731 (comment)> you
seemed very worried about all the work you put into tikz-3dtools being in
vain, so I went ahead, isolated the 3dtools library from the rest of the
PR and published it separately for you convenience. It is entirely under
your control, so if you want to have it taken down, just email
***@***.***
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#714?email_source=notifications&email_token=AISROXHVB2PQAWVMRPICSZDQUDNPRA5CNFSM4IFC4T72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEIEXDA#issuecomment-554716044>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISROXBV5NCZKTKIEFY6WDLQUDNPRANCNFSM4IFC4T7Q>
.
|
fixed typos, removed duplicated example
The main part of this PR has been merged (the |
I am so sorry for the aux files. I tried to remove them by removing them in the directory and saying
git commit -m "removed aux file"
and indeeddeleted: bboxtest.aux
deleted: bboxtest.log
deleted: bboxtest.tex.bck
deleted: tikzlibrarybbox.code.tex.bck
but the files are still there. Is there anywhere a manual for git or do I have to continue guessing?