Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbox library #714

Closed
wants to merge 42 commits into from
Closed

bbox library #714

wants to merge 42 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2019

I am so sorry for the aux files. I tried to remove them by removing them in the directory and saying git commit -m "removed aux file" and indeed
deleted: bboxtest.aux
deleted: bboxtest.log
deleted: bboxtest.tex.bck
deleted: tikzlibrarybbox.code.tex.bck
but the files are still there. Is there anywhere a manual for git or do I have to continue guessing?

Tall Marmot added 6 commits July 18, 2019 19:27
…in rare cases the bounding box can be wrong. this happens when the curve is merely back and forth, i.e. the quadratic equation becomes almost linear but the linear coefficient is something of the form 0/0. I am not an expert in TeX regularization, but there should be some means. On the other hand, implementing it will most likely really lead to performance issues.
@hmenke
Copy link
Member

hmenke commented Jul 19, 2019

This needs quite a bit of work. I'll see whether I can do something over the weekend.

@hmenke
Copy link
Member

hmenke commented Jul 19, 2019

A manual for git can be found on https://git-scm.com/

@ghost
Copy link
Author

ghost commented Jul 19, 2019 via email

@hmenke hmenke force-pushed the master branch 2 times, most recently from 6d4a25c to 0517551 Compare August 3, 2019 08:22
@hmenke hmenke added this to the 3.1.5 milestone Nov 5, 2019
\tikzset{reuse path/.code={%
\pgfsyssoftpath@setcurrentpath{#1}}
}% unfortunately this is *not* the definition of the `use path` key that has
% been added to the pgfmanual!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... What's the fundamental difference here?

\tikzoption{use path}{\tikz@addmode{\pgfsyssoftpath@setcurrentpath#1}}%

current reverse clip'/.style={insert path={{% https://tex.stackexchange.com/a/127045
(current bounding box.south east) -|
(current bounding box.north west) -| cycle
}}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current reverse clip and current reverse clip' are the same thing or am I missing something?

}}},
even odd clip/.code={% https://tex.stackexchange.com/a/76216
\pgfseteorule}}
\tikzset{Venn diagram/.style={/utils/exec=\tikzset{venn/.cd,#1},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just Venn diagram/.style={venn/.cd,#1}?

execute at begin scope={
\pgfmathtruncatemacro{\pgfutil@tmpD}{dim(\pgfkeysvalueof{/tikz/venn/labels})}
\ifnum\pgfutil@tmpD<\pgfkeysvalueof{/tikz/venn/number of sets}
\tikzerror{Less labels then Venn sets.}%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fewer labels than Venn sets.”

yshift=-\pgfkeysvalueof{/tikz/venn/frame margin}]Venn Box.south west)
rectangle ([xshift=\pgfkeysvalueof{/tikz/venn/frame margin},
yshift=\pgfkeysvalueof{/tikz/venn/frame margin}]Venn Box.north east);
},on background layer},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this where the enormous execute at begin scope ends? I can't really see for the lack of indentation. Also when doing this you have to somehow make sure that Venn diagram can only be used as a scope or picture option.

@@ -0,0 +1,50 @@
\documentclass{article}
\usepackage{tikz}
\usepackage{tikz-3dplot}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evidently this library is meant for interop with tikz-3dplot, which is why I won't merge this into mainline PGF/TikZ. I'm not convinced by having more user macros. I'm also not convinced by \pgfmathtdparse. That seems very fragile.

Copy link
Member

@hmenke hmenke Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In response to #731 (comment) which was probably meant to appear here:


The 3dtools library introduces a whole bunch of new user macros, like \pgfmathtdparse, \pgfmathprintvector, \tdparse (is that the same as \pgfmathtdparse?) and \orthmat (is this meant for users? If not, why is it public?). This somewhat collides with the PGF/TikZ philosophy of using keys and values instead of commands.

Right now, the whole 3dtools library is in a single file tikzlibrary3dtools.code.tex. It uses the LaTeX package calculator and \newcommand, i.e. it cannot be used with other formats. Also it defines macros with \pgf... prefix which clearly belong in a PGF rather than a TikZ library.

Last but not least, I am totally not stopping you from publishing this library independently on CTAN for use with TikZ, just like tikz-cd or tikz-feynman. So while I can understand your disappointment that this is probably not going to be in mainline without some vast improvement, I am slightly confused by the accusation of “destroying hours of work”.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have packaged up tikz-3dtools and put it here: https://github.com/pgf-tikz/tikz-3dtools
Release v1.0 is also submitted to CTAN already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tikz-3dtools has appeared on CTAN and should be in TeX Live soon.
https://ctan.org/pkg/tikz-3dtools

@@ -0,0 +1,161 @@
\tikzset{%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some refactoring I have merged the bbox library into PGF/TikZ. Thank you for your contribution.

@@ -0,0 +1,174 @@
% Copyright 2019 by an anonymous marmot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to merge the venn library, but the code is lacking in some places. Would it also be possible to make it a PGF library rather than a pure TikZ library?

@ghost
Copy link
Author

ghost commented Nov 16, 2019 via email

@hmenke
Copy link
Member

hmenke commented Nov 17, 2019

I'm getting more and more confused. In #731 (comment) you seemed very worried about all the work you put into tikz-3dtools being in vain, so I went ahead, isolated the 3dtools library from the rest of the PR and published it separately for your convenience. It is entirely under your control, so if you want to have it taken down, just email [email protected].

@ghost
Copy link
Author

ghost commented Nov 17, 2019 via email

@hmenke
Copy link
Member

hmenke commented Nov 21, 2019

The main part of this PR has been merged (the bbox library). I'm therefore closing this for now. You can open a new PR with your other changes. Please rebase onto master before doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants