Resolve missing gnuplot plots in manual #1239
Conversation
build.lua
Outdated
| -- Execute cp() manually to keep the directory structure, otherwise if | ||
| -- "plots/*.table" is appended to docfiles, ".table" files will be copied | ||
| -- directly to typesetdir, not typesetdir .. "/plots". | ||
| cp("plots/*.table", docfiledir, typesetdir .. "/plots") |
There was a problem hiding this comment.
To keep treatments unified, do similar special treatment for "images/*.jpg"?
There was a problem hiding this comment.
Alternatively, appending the subdir name to docfiles does the trick. @josephwright Is this the expected behavior or a misused "feature"?
diff --git a/build.lua b/build.lua
index 7bf4f678..9e712ddb 100644
--- a/build.lua
+++ b/build.lua
@@ -12,7 +12,7 @@ docfiledir = "./doc/generic/pgf"
docfiles =
{
"RELEASE_NOTES.md", "description.html", -- Part of the release script
- "color.cfg", "pgfmanual.cfg", "images/*.jpg", "*.tex" -- Build the PDF
+ "color.cfg", "pgfmanual.cfg", "images", "plots", "*.tex" -- Build the PDF
}
tdsroot = "generic"
typesetfiles = {"pgfmanual.tex"}
There was a problem hiding this comment.
Another idea: if \input@path/\l_file_search_path_seq is respected by \pgfutil@IfFileExists and \pgfutil@InputIfFileExists (see #1259), then we can drop prefix plots/ in manual examples
There was a problem hiding this comment.
Alternatively, appending the subdir name to
docfilesdoes the trick. @josephwright Is this the expected behavior or a misused "feature"?
From conversation in latex3/l3build#331 and a casual check in l3build source, yes it is supported. I tend to use this currently undocumented feature in pgf's l3build configuration.
As this PR also promotes missing plot data file from warning to error, feature breaking change in l3build will be caught.
|
muzimuzhi
force-pushed
the
gnuplots-files
branch
2 times, most recently
from
2e3b1f7
to
2386280
Compare
muzimuzhi
changed the title
muzimuzhi
force-pushed
the
gnuplots-files
branch
from
2386280
to
dc1b6a8
Compare
Signed-off-by: Yukai Chou <[email protected]>
Signed-off-by: Yukai Chou <[email protected]>
Signed-off-by: Yukai Chou <[email protected]>
muzimuzhi
force-pushed
the
gnuplots-files
branch
from
d1ada29
to
4da661c
Compare
|
As d1ada29 didn't pass the "Check commits" check, I reorganized commits and reworded CHANGELOG entries (perhaps overly), and force pushed again (sorry). |
Motivation for this change
The last commit is just temp and should be removed before merging.
Fixes #1191
Fixes #1238
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: