Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space in pgfmathdeclarefunction shifts plots to the right. #915

Closed
clecap opened this issue Sep 2, 2020 · 3 comments
Closed

Space in pgfmathdeclarefunction shifts plots to the right. #915

clecap opened this issue Sep 2, 2020 · 3 comments

Comments

@clecap
Copy link

clecap commented Sep 2, 2020

There already is an overview and analysis of this on stackexchange, together with minimal example.

The title may be a bit misleading, as the core problem is most likely not connected with the samples parameter but with blanks in the function declaration. See:

https://tex.stackexchange.com/questions/561108/tikz-issue-with-samples-parameter-minimal-example

@hmenke
Copy link
Member

hmenke commented Sep 2, 2020

  1. This issue is in an invalid format because every issue MUST include a MWE. Is there something wrong with using the issue tenplate?

  2. It's an exact duplicate of spurious spaces in \pgfmathdeclarefunction #508. Search exisiting issues before opening a new one.

  3. It won't be fixed because it breaks usage of pgfkeys in functions which many clients rely on. Just fix your definition.

@clecap
Copy link
Author

clecap commented Sep 3, 2020

  1. This issue is in an invalid format because every issue MUST include a MWE.

As are issues 869, 900, 908, 904. ;-)

Is there something wrong with using the issue tenplate?

Basically not. Unless you want to learn about all issues, bugs and problems. And sometimes there are reasons why submitters do not follow strict templates. Such as not being sure about having a bug or having the same information already at a different place. But maybe linking to info somewhere else is not ok as well?

  1. It's an exact duplicate of spurious spaces in \pgfmathdeclarefunction #508. Search exisiting issues before opening a new one.

No, it's not. If you read the linked source and the edits there you will see that the issue started out from a completely different observation and only later evolved into something similar.

  1. It won't be fixed because it breaks usage of pgfkeys in functions which many clients rely on. Just fix your definition.

Sometimes design decisions in the past were wrong or only over time are understood to have been inconvenient. They may affect future development in so far that a modification breaks code that is relied upon. There are pathways out of this dilemma using versioning and renaming. They can be applied here. And, I think, they should.

Yes, TeX has a peculiar way of dealing with blanks. This makes life complicated for package developers. But, from the users perspective, there is no good reason why a blank in a function definition at some place in the code should end up shifting layout positions at a completely different place in the code - and depend highly on the samples parameter as well. Well...unless you like surprises, of course. If you have nested definitions and high values of `samples' it can shift the diagram completely off the screen. I consider this a problem. But we can disagree on that :-)

@hmenke
Copy link
Member

hmenke commented Sep 3, 2020

Please don't ever report an issue again, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants