Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing Windows support? #1927

Open
workingjubilee opened this issue Oct 24, 2024 · 0 comments
Open

Finishing Windows support? #1927

workingjubilee opened this issue Oct 24, 2024 · 0 comments
Labels
build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph cargo-pgrx sys:windows

Comments

@workingjubilee
Copy link
Member

Thanks to the efforts of @usamoi, @passcod, and many bug reports and patches from others besides, we are within (slightly speculatively?) about 10 PRs of fixing Windows. Some of these may be very small patches.

Currently, cargo-pgrx builds on Windows, but does not quite finish cargo pgrx init:

   0: %1 is not a valid Win32 application. (os error 193)

Location:
   cargo-pgrx\src\command\init.rs:450

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ SPANTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

   0: cargo_pgrx::command::init::download_postgres with pg_version=12.20
      at cargo-pgrx\src\command\init.rs:237

We probably mostly need to fix most of the shellouts and some of the path searches in the build system elements of pgrx so that they are more platform-neutral. This should mostly not require specialist knowledge (relative to "knowing a smidge of Rust", anyways).

@workingjubilee workingjubilee added cargo-pgrx sys:windows build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-sys Regarding the "build system" of pgrx which is split between cargo-pgrx, pg-sys, and sql-entity-graph cargo-pgrx sys:windows
Projects
None yet
Development

No branches or pull requests

1 participant