Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection of DI on GlobalDrupalSniff is too loose. #238

Closed
b-sharpe opened this issue Oct 25, 2024 · 1 comment · May be fixed by #239
Closed

Detection of DI on GlobalDrupalSniff is too loose. #238

b-sharpe opened this issue Oct 25, 2024 · 1 comment · May be fixed by #239

Comments

@b-sharpe
Copy link

Currently the following must be true to catch \Drupal:: calls in DI classes:

  1. Class doesn't extend anything OR Doesn't extend one of those defined as base classes
  2. Is not a service itself
  3. Doesn't implement ContainerInjectionInterface

So this omits a lot of legit cases of plugins as they commonly will use ContainerFactoryPluginInterface
@b-sharpe b-sharpe mentioned this issue Oct 25, 2024
Open
@klausi
Copy link
Collaborator

klausi commented Nov 29, 2024

Issues are done at https://www.drupal.org/project/issues/coder , please search or create one there!

@klausi klausi closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds better detection of DI classes to global sniff. b-sharpe/coder
2 participants
@klausi @b-sharpe