add JSONDecodeError

pfeairheller · May 2, 2024 · 36fa77f · 36fa77f
1 parent 90c5432
commit 36fa77f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/keria/app/credentialing.py b/src/keria/app/credentialing.py
@@ -553,7 +553,7 @@ def on_post(self, req, rep, name):
                 anc = serdering.SerderKERI(sad=httping.getRequiredParam(body, "ixn"))
             else:
                 anc = serdering.SerderKERI(sad=httping.getRequiredParam(body, "rot"))
-        except kering.ValidationError as e:
+        except (kering.ValidationError, json.decoder.JSONDecodeError) as e:
             rep.status = falcon.HTTP_400
             rep.text = e.args[0]
             return

diff --git a/tests/app/test_credentialing.py b/tests/app/test_credentialing.py
@@ -293,11 +293,6 @@ def test_issue_credential(helpers, seeder):
         assert result.json == {'description': "name is not a valid reference to an identifier",
                                'title': '404 Not Found'}
 
-        result = client.simulate_post(path="/identifiers/issuer/credentials", body=json.dumps({}).encode("utf-8"))
-        assert result.status_code == 400
-        assert result.json == {'description': "required field 'acdc' missing from request",
-                               'title': '400 Bad Request'}
-
         result = client.simulate_post(path="/identifiers/issuer/credentials", body=json.dumps(body).encode("utf-8"))
         op = result.json
 
@@ -309,6 +304,9 @@ def test_issue_credential(helpers, seeder):
 
         assert agent.credentialer.complete(creder.said) is True
 
+        body["acdc"]["a"]["LEI"] = "ACDC10JSON000197_"
+        result = client.simulate_post(path="/identifiers/issuer/credentials", body=json.dumps(body).encode("utf-8"))
+        assert result.status_code == 400
 
 def test_credentialing_ends(helpers, seeder):
     salt = b'0123456789abcdef'