Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill PEX_IGNORE_ERRORS #774

Closed
benjyw opened this issue Oct 16, 2019 · 1 comment
Closed

Kill PEX_IGNORE_ERRORS #774

benjyw opened this issue Oct 16, 2019 · 1 comment
Assignees

Comments

@benjyw
Copy link
Collaborator

benjyw commented Oct 16, 2019

It's not a good idea to allow creation of a pex that we know has missing requirements.

@benjyw benjyw self-assigned this Oct 16, 2019
@jsirois
Copy link
Member

jsirois commented Aug 9, 2024

The introduction of --exclude in #2281, improved in #2409 and 1st released in v2.1.151 actually necessitates this; so I'm going to close as not planned. #2426 tracks a safer version of --exclude that won't require ignoring errors, but cases still exist where --exclude is correct without replacement as outlined in #2097.

@jsirois jsirois closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants