Skip to content

Commit

Permalink
cli: allow node status to work on unavailable/broken clusters
Browse files Browse the repository at this point in the history
Expand the `crdb_internal.gossip_liveness` and
`crdb_internal.gossip_nodes` tables to include columns needed to satisfy
the basic usage of `node status`. Specifically, added `address`,
`build`, `started_at`, `updated_at` and `replicas` columns. Changed
`node status` to use `gossip_{liveness,nodes}` instead of
`kv_node_status`. The latter table requires the range containing the
consistent node status descriptors to be available, while
`gossip_{liveness,nodes}` only retrieves info from gossip.

`node status` and `node status --decommission` will work on
unavailable/broken clusters as long as the node they are pointed to is
up. `node status {--stats,--ranges,--all}` continue to require a
reasonably healthy cluster.

Fixes cockroachdb#16489

Release note (cli change): Enhance `node status` to work on
unavailable/broken clusters.
  • Loading branch information
petermattis committed Aug 3, 2018
1 parent 002f3c0 commit c445a94
Show file tree
Hide file tree
Showing 11 changed files with 435 additions and 127 deletions.
106 changes: 89 additions & 17 deletions c-deps/libroach/protos/roachpb/metadata.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c445a94

Please sign in to comment.