Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Allow centering of all columns in 'Only scroll as necessary' #66

Closed
humanplayer2 opened this issue Oct 22, 2024 · 6 comments

Comments

@humanplayer2
Copy link

In Only scroll as necessary scrolling mode, it is not possible to center on columns if there are not wide enough columns on its sides, cf. discussion in #35.

It would be nice if it was possible to center on arbitrary columns.

@peterfajdiga
Copy link
Owner

peterfajdiga commented Oct 22, 2024 via email

@humanplayer2
Copy link
Author

Thank you, yes, but it scrolls more than necessary for me.

E.g. say I have three windows A, B, C that take up respectively 30%, 20%, 30% of my ultrawide monitor.

  • I work in C, and want that centered.
  • When C is centered, A is moved beyond the left edge of the screen: that's OK, I only need it later.
  • I have information in B that I copy into C. A I only need later. .

I can move focus to C and center it. That's nice. However, when I move focus to B, B is centered, which I don't want. When I move back to C, I have to re-center it.

@xegx
Copy link

xegx commented Oct 26, 2024

I would also appreciate this feature.

Then the shortcut to center the focused window (Meta+Alt+Return by default) would have a consistent outcome in the scroll as necessary mode: center the focused window no matter what, even if some 'blank' desktop was shown to the right or left.

That might be the case if the focused window was in the start or end column, but also if the focused window was close enough to the start or end column that centering it would also reveal some of the 'blank' desktop to the left or right of the screen.

Your kwin script is very useful on wide monitors. Thank you for your work.

@peterfajdiga
Copy link
Owner

I misunderstood the original comment in this issue. So if I understand correctly now, this is the same as #35 ?

If yes, this has already been fixed in commit fb1047c, but I haven't created a release with the fix yet.

@xegx
Copy link

xegx commented Oct 27, 2024

I've just tried revision c60cfeb and the "Center focused window (Scrolls so that the focused window is centered in the screen)" command now operates as I'd prefer (as described in my previous comment) when using the "Scroll as necessary" mode.

I won't speak for the original feature requester but I find this Karousel behaviour more consistent and preferable. I also think it fulfills this feature request.

I think this current feature request is related to the last line of #35 where the feature requester asks for a second feature. So I don't think this #66 is exactly the same as #35 because two features were requested there.

Thanks very much.

@humanplayer2
Copy link
Author

I agree with @xegx, both wrt consistency of behavior and wrt how this was supposed to relate to #35 . Thank you @peterfajdiga for implementing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants