From 14cd1976329dc052d8d0ef5379aeb970e59aa878 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Barab=C3=A1s?= Date: Fri, 13 Dec 2024 08:46:19 -0800 Subject: [PATCH] fix: triage automation updates (#3907) # Overview/Summary triage automation updates ## This PR fixes/adds/changes/removes 1. remove ita05 2. change ita04 to apply to PRs too 3. update ita011 to only get triggered if the author responded and also remove "no recent activity" ### Breaking Changes 1. remove ita05 ## As part of this Pull Request I have - [x] Read the Contribution Guide and ensured this PR is compliant with the guide - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/Azure-Verified-Modules/pulls) - [ ] Associated it with relevant [GitHub Issues](https://github.com/Azure/Azure-Verified-Modules/issues) or ADO Work Items (Internal Only) - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/Azure-Verified-Modules/) - [x] Ensured PR tests are passing - [x] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.) --------- Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com> --- .github/policies/eventResponder.yml | 6 +- .github/policies/scheduledSearches.yml | 95 +++++++++++++------------- 2 files changed, 52 insertions(+), 49 deletions(-) diff --git a/.github/policies/eventResponder.yml b/.github/policies/eventResponder.yml index ca47bcabc9..3c433335c4 100644 --- a/.github/policies/eventResponder.yml +++ b/.github/policies/eventResponder.yml @@ -93,7 +93,7 @@ configuration: label: "Status: Won't Fix :broken_heart:" - closeIssue - - description: 'ITA11 - When a reply from anyone to an issue occurs, remove the "Needs: Author Feedback :ear:" label and label with "Needs: Attention :wave:"' + - description: 'ITA11 - When the author replies, remove the "Needs: Author Feedback :ear:" label and label with "Needs: Attention :wave:"' if: - or: - payloadType: Pull_Request_Review_Comment @@ -103,9 +103,13 @@ configuration: action: Closed - hasLabel: label: "Needs: Author Feedback :ear:" + - isActivitySender: + issueAuthor: true then: - removeLabel: label: "Needs: Author Feedback :ear:" + - removeLabel: + label: "Status: No Recent Activity :zzz:" - addLabel: label: "Needs: Attention :wave:" diff --git a/.github/policies/scheduledSearches.yml b/.github/policies/scheduledSearches.yml index 9f0df3e35a..200633e2ee 100644 --- a/.github/policies/scheduledSearches.yml +++ b/.github/policies/scheduledSearches.yml @@ -181,12 +181,11 @@ configuration: - addLabel: label: "Needs: Immediate Attention :bangbang:" - - description: "ITA04 - Label issues that have been marked as requiring author feedback but have not had any activity for 4 days." + - description: "ITA04 - Label issues and PRs that have been marked as requiring author feedback but have not had any activity for 4 days." frequencies: - hourly: hour: 3 filters: - - isIssue - isOpen - hasLabel: label: "Needs: Author Feedback :ear:" @@ -208,52 +207,52 @@ configuration: > - The "Status: No Recent Activity :zzz:" label must be removed. > - If applicable, the "Status: Long Term :hourglass_flowing_sand:" or the "Needs: Module Owner :mega:" label must be added. - - description: 'ITA05A - Close issues that have been marked as requiring author feedback but have not had any activity for 3 days, unless it''s been marked with the "Status long term" label.' - frequencies: - - hourly: - hour: 3 - filters: - - isIssue - - isOpen - - hasLabel: - label: "Needs: Author Feedback :ear:" - - hasLabel: - label: "Status: No Recent Activity :zzz:" - - isNotLabeledWith: - label: "Needs: Module Owner :mega:" - - noActivitySince: - days: 3 - actions: - - addReply: - reply: | - > [!WARNING] - > @${issueAuthor}, this issue will now be closed, as it has been marked as requiring author feedback but has not had any activity for **7 days**. + # - description: 'ITA05A - Close issues that have been marked as requiring author feedback but have not had any activity for 3 days, unless it''s been marked with the "Status long term" label.' + # frequencies: + # - hourly: + # hour: 3 + # filters: + # - isIssue + # - isOpen + # - hasLabel: + # label: "Needs: Author Feedback :ear:" + # - hasLabel: + # label: "Status: No Recent Activity :zzz:" + # - isNotLabeledWith: + # label: "Needs: Module Owner :mega:" + # - noActivitySince: + # days: 3 + # actions: + # - addReply: + # reply: | + # > [!WARNING] + # > @${issueAuthor}, this issue will now be closed, as it has been marked as requiring author feedback but has not had any activity for **7 days**. - > [!TIP] - > In case this issue needs to be reopened (e.g., the author responds after the issue was closed), the "Status: No Recent Activity :zzz:" label must be removed. - - closeIssue + # > [!TIP] + # > In case this issue needs to be reopened (e.g., the author responds after the issue was closed), the "Status: No Recent Activity :zzz:" label must be removed. + # - closeIssue - - description: 'ITA05B - Close issues that have been marked as requiring author feedback but have not had any activity for 3 days, unless it''s been marked with the "Status long term" label.' - frequencies: - - hourly: - hour: 3 - filters: - - isIssue - - isOpen - - hasLabel: - label: "Needs: Author Feedback :ear:" - - hasLabel: - label: "Status: No Recent Activity :zzz:" - - isNotLabeledWith: - label: "Status: Long Term :hourglass_flowing_sand:" - - noActivitySince: - days: 3 - actions: - - addReply: - reply: | - > [!WARNING] - > @${issueAuthor}, this issue will now be closed, as it has been marked as requiring author feedback but has not had any activity for **7 days**. + # - description: 'ITA05B - Close issues that have been marked as requiring author feedback but have not had any activity for 3 days, unless it''s been marked with the "Status long term" label.' + # frequencies: + # - hourly: + # hour: 3 + # filters: + # - isIssue + # - isOpen + # - hasLabel: + # label: "Needs: Author Feedback :ear:" + # - hasLabel: + # label: "Status: No Recent Activity :zzz:" + # - isNotLabeledWith: + # label: "Status: Long Term :hourglass_flowing_sand:" + # - noActivitySince: + # days: 3 + # actions: + # - addReply: + # reply: | + # > [!WARNING] + # > @${issueAuthor}, this issue will now be closed, as it has been marked as requiring author feedback but has not had any activity for **7 days**. - > [!TIP] - > In case this issue needs to be reopened (e.g., the author responds after the issue was closed), the "Status: No Recent Activity :zzz:" label must be removed. - - closeIssue + # > [!TIP] + # > In case this issue needs to be reopened (e.g., the author responds after the issue was closed), the "Status: No Recent Activity :zzz:" label must be removed. + # - closeIssue