[115] tests keep running and running tests number increases #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test run was only ended when it was cancelled.
npm protests about a security issue. When packaging the extension, a warning complains about the version of vsce.
When testing a module, with or without classes, it may be necessary to restart the background process. There is the `pester.runTestsInNewProcess` setting for that, but one may not want to restart the process for each test run. This commit introduces a new command.
Tests were failing for two reasons: - when `pwsh` is not installed (Vanilla PowerShell 5 on Windows) - when testing the `PowerShell.exec()` method. AFAIK, this occurs when the execution of the PowerShell is too fast For the first one, I have introduced a constant taking the platform into account. For the second one, when check the that the stream is still alive before waiting for it.
|
I'm amazed you were able to untangle my maze of code, great work! Here's the built VSIX of your PR, if you can verify it fixes it then I'll merge, I'll confirm in the main branch as well. |
|
It works for me. Let's see if other people reports the same. |
|
@antoinemartin thank you for this! 🙇 After running this proposed change for a few days now it made the extension fun to use again. It feels more stable, before it could just suddenly stop working so before this I haven't used the extension for months. Awesome work 🙂 |
|
@johlju thanks for the confirmation! I'll merge and release. |
|
Published and released! Thanks all for your input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fix is the first commit. It can be cherry-picked if the rest of the PR is not considered useful.
I added a command to stop the background process. This is useful when testing a module with
InModuleScopethat needs to be re-imported while keeping the process to quicly run tests on save.The rest are minor adjustments.
Thank you for this great extension.
Fixes #115