-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus v3 #272
Docusaurus v3 #272
Conversation
Thanks for creating this one. We still have some time but this makes it pretty clear what needs to be done. 👍 |
And yes, the Alt3 module should definitely be able escape the curly brackets (especially since that fix is compatible with docusaurus v2) |
@fflaten would you be able to test the Alt3 module artifact produced in https://github.com/alt3/Docusaurus.Powershell/actions/runs/5829982515?pr=169? If it generates the expected markdown with escaped curly brackets, I will publish a new version. |
No diff besides comment in sidebar. All good! 🎉 |
Thank you for testing, much appreciated. If you find anything else feel free to let me know 💃 Released in https://www.powershellgallery.com/packages/Alt3.Docusaurus.Powershell/1.0.35 |
Great work! Will do. Hopefully not more issues to come. |
3.0-rc.0 adds support for TS config files. Switch or stay with JS? facebook/docusaurus#9317 |
I have been waiting to see how they do the ts config and would (and will) personally go for it. |
Cool. I'll let you handle that in a separate PR 🙂 |
This needs to be fixed in source. MDX v2 allows expressions inside curly braces outside of codefences
Manually fixed as v4 docs are not updated anymore MDX v2 allows expressions inside curly braces outside of codefences
clsx is faster, has same syntax and is also used in docusaurus
Summary got wrapped in the contents paragraph-element MDX v2 doesn't produce blocks for single line ocntent. We fix this by adding a blank line after summary, or just wrap text in ex. div-element
Support removed in 3.0.0-beta.0. Fix was documented in build error
`:::caution` is deprecated in v3. `:::warning` has been updated with the same styling, so only real change is default title.
Remove xml as additional language
Removes unused url-loader and file-loader. Adds prism-react-renderer as direct deps to support strict package manages without hoisting.
Not sure if we'd like to merge this (when reviewed) or not. Feel free to close if it should be split into multiple PRs :) |
I have no issues with merging this as it is. I could not detect any issues in the preview so just let me know if you feel confident as well and I will merge. |
Nice. LGTM on my end 🙂 |
Woohoo 💃 |
Upgrades the docs website to Docusaurus v3 with MDX v3, prism-react-renderer v2 and React 18.
Also includes some minor dependency-cleanup.
Related links:
Lessons learned during migration:
<details>
elements as summary-element (title) got wrapped in first paragraph.version-v4.0/
from all keys and links in the json.Feel free to commit to this with new builds or other fixes. Just thought we could verify early.
Fix #273