Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Get-EquivalencyOption with parameters #2477

Closed
nohwnd opened this issue May 20, 2024 · 2 comments · Fixed by #2502
Closed

replace Get-EquivalencyOption with parameters #2477

nohwnd opened this issue May 20, 2024 · 2 comments · Fixed by #2502
Labels
Assertions For issues related with assertions
Milestone
6.0.0

Comments

@nohwnd
Copy link
Member

nohwnd commented May 20, 2024 •
edited
Loading

Get-EquivalencyOption is not exposed, so unable to customize/no docs on expected hashtable.

Just curious, why opt for object/hashtable vs parameters for this? Parameters are easier to document and splatting solves reusable parameters. If sticking with options-object, should it be typed?

Originally posted by @fflaten in #2428 (comment)
@nohwnd nohwnd added the Assertions For issues related with assertions label May 20, 2024
@nohwnd nohwnd added this to the 6.0.0 milestone May 20, 2024
@nohwnd
Copy link
Member Author

nohwnd commented May 20, 2024

Exported.

@nohwnd nohwnd mentioned this issue May 20, 2024
Merged
5 tasks
@nohwnd
Copy link
Member Author

nohwnd commented May 20, 2024

get-equivalent needs more care, there is not support for Because.

Strict Order is not exposed and might not even work.

@nohwnd nohwnd changed the title Get-EquivalencyOption is not exposed, so unable to customize/no docs on expected hashtable. replace Get-EquivalencyOption with parameters Jun 13, 2024
@fflaten fflaten mentioned this issue Jun 13, 2024
Merged
5 tasks
@nohwnd nohwnd mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Assertions For issues related with assertions
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Replace Get-EquivalencyOptions with parameters pester/Pester
1 participant
@nohwnd