Added new Error Art #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 6, 2020 15:38
.DS_Store to gitignore to make it easy for macOS contributors
Added Jumbo the elephant for an ASCII error message also added .DS_Store to gitignore to make it easy for macOS contributors
Added jumbo the elephant to errorArt also added .DS_Store to gitignore to make it easy for macOS contributors
Added Jumbo the Elephant in errorArt.go Also added .DS_Store in gitignore to make it easier for macOS contributors in the future
Om-Amitesh
requested review from
Gituser143,
MadhavJivrajani and
metonymic-smokey
as code owners
MadhavJivrajani
requested changes
Oct 6, 2020
There was a problem hiding this comment.
There seems to be an error in formatting, please run go fmt errorArt.go and see if you can rectify the same. Let us know if you need any help solving this!
Also just a suggestion, its up to you to take it or not: try and put a clearer ascii art, what you've put is great but there could be a higher quality one! Either way its good with me.
|
@Om-Amitesh There seems to be an issue with code formatting. Please format your code and push again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Jumbo the elephant and also added .DS_Store in gitignore to make it easy for future macOS contributors
Wrt #7
Type of change
Please delete options that are not relevant.
Checklist:
go fmton my code (reference)