Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In tomcat with -Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true, the FilterTools.getRelativePath does not works correctly #1026

Open
miguoliang opened this issue Jun 26, 2018 · 2 comments · May be fixed by #1222
Open

In tomcat with -Dorg.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true, the FilterTools.getRelativePath does not works correctly #1026

miguoliang opened this issue Jun 26, 2018 · 2 comments · May be fixed by #1222
Labels
Bug

Comments

@miguoliang
Copy link

miguoliang commented Jun 26, 2018 •
edited
Loading

if a URL contains a %2F, e.g. http://localhost:8080/api/v1/permissionrole/permission/get%2Fabc, the HttpServletRequest.getRequestURI could return the raw uri correctly, but the FilterTools.getRelativePath decoded the %2F in the path. Maybe it's not right.

the correct result should be /api/v1/permissionrole/permission/get%2Fabc, but /api/v1/permissionrole/permission/get/abc returned by FilterTools.getRelativePath.

this PR works for this case, #553.

Thanks.

spark/src/main/java/spark/servlet/FilterTools.java

Line 55 in c697d98

path = URLDecoder.decode(path, "UTF-8");

@tipsy tipsy added the Bug label Mar 21, 2019
This was referenced Apr 23, 2021
Open
Merged
Bugjudger added a commit to Lloyd-Pottiger/spark that referenced this issue Apr 23, 2021
@Bugjudger
Merge pull request #1 from Bugjudger/Fix_Non_ASCII_Character_in_URL
97c115f 
Solve the problem of non ASCII characters. Try to fix perwendel#1026
@Bugjudger
Copy link

I would like to work on this issue

@Bugjudger
Copy link

I want to use UTF-8 to solve this problem. When the path in URL has %, the user can not put the URL in the address bar in the browser directly. They should encode URL in UTF-8 .
There are two ways:

  1. url_encode = encodeURL(URL) (in JavaScript language). Then put url_encode into address bar,
  2. open the setting: send url by UTF-8 in browser. And then change the % to %25.

lepe pushed a commit to Intellisrc/spark that referenced this issue Aug 11, 2022
Fixed issue perwendel#1026 implementation and unit test.
de9a849
@lepe lepe mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solve the problem of non-ASCII characters in URL. Try to fix #1026
3 participants
@tipsy @miguoliang @Bugjudger