Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar NaN Issue #64

Open
amalnanavati opened this issue Jun 2, 2023 · 2 comments
Open

Progress Bar NaN Issue #64

amalnanavati opened this issue Jun 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@amalnanavati
Copy link
Contributor

When the robot transitions to a RobotMotion state, it first momentarily renders the progressBar with NaN before actually rendering the progress. See this screen recording.

This issue is about understanding why that is happening and fixing it.

@amalnanavati amalnanavati added the bug Something isn't working label Jun 2, 2023
@Raidakarim
Copy link
Contributor

I don't see this bug on my end. I checked in both Firefox and Chromium browser in Ubuntu VM. Not sure if it is your setting-specific(?!).

@amalnanavati
Copy link
Contributor Author

I delved more into this bug. It seems like for some reason, the first feedback message that is received on a RobotMotion is sometimes a feedback message from the previous action call. This is reproduceable on my computer if I log the feedback message at the top of the callback function, and then alternate between the same few actions multiple times (e.g., MoveToRestingPosition, MoveToMouth).

This makes me think that either:

  1. We are incorrectly using ros2actions from roslibjs.
  2. There is a bug in ros2actions from roslibjs (e.g., they should have called removeAllEventListeners on destroyActionClient or something similar).
  3. There is a bug in rosbridge_websocket.

The reason I know it's not a bug in ada_feeding is that when we call the same actions from the command line interface, we don't see this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants