Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] Remove overridden parameters that are set to the default value #147

Open
amalnanavati opened this issue Dec 23, 2023 · 1 comment

Comments

@amalnanavati
Copy link
Contributor

As of #146, even if overridden parameters are set to the default value, they stay in ada_feeding/config/ada_feeding_action_servers_currentl.yaml. Instead, in create_action_servers.py, we should add a check for whether their value is the same as the default value, and if so, remove them from self.overridden_parameters. Within self.save_overridden_parameters(), if len(self.overridden_parameters) == 0, save the file with just an empty string within overridden_parameters, same as the current file in the git repo.

@amalnanavati
Copy link
Contributor Author

The exact way to address this has changed with #172 , but overall it could be helpful to not save a custom parameter if it is the same as the default, for readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant