You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of #146, even if overridden parameters are set to the default value, they stay in ada_feeding/config/ada_feeding_action_servers_currentl.yaml. Instead, in create_action_servers.py, we should add a check for whether their value is the same as the default value, and if so, remove them from self.overridden_parameters. Within self.save_overridden_parameters(), if len(self.overridden_parameters) == 0, save the file with just an empty string within overridden_parameters, same as the current file in the git repo.
The text was updated successfully, but these errors were encountered:
The exact way to address this has changed with #172 , but overall it could be helpful to not save a custom parameter if it is the same as the default, for readability.
As of #146, even if overridden parameters are set to the default value, they stay in
ada_feeding/config/ada_feeding_action_servers_currentl.yaml
. Instead, increate_action_servers.py
, we should add a check for whether their value is the same as the default value, and if so, remove them fromself.overridden_parameters
. Withinself.save_overridden_parameters()
, iflen(self.overridden_parameters) == 0
, save the file with just an empty string withinoverridden_parameters
, same as the current file in the git repo.The text was updated successfully, but these errors were encountered: