From 0c8c2d3244952a1080bdae53c6ed34bb5b85da67 Mon Sep 17 00:00:00 2001 From: Ed J Date: Wed, 18 Sep 2024 19:23:11 +0000 Subject: [PATCH] it seems catalogs *are* now supported - make statistics_info use them --- lib/DBD/mysql.pm | 10 ++++------ t/40keyinfo.t | 5 +++++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/DBD/mysql.pm b/lib/DBD/mysql.pm index bc3c4156..b2ecef35 100644 --- a/lib/DBD/mysql.pm +++ b/lib/DBD/mysql.pm @@ -738,12 +738,10 @@ EOF my @where; my @bind; - # catalogs are not yet supported by MySQL - -# if (defined $catalog) { -# push @where, 'TABLE_CATALOG = ?'; -# push @bind, $catalog; -# } + if (defined $catalog) { + push @where, 'TABLE_CATALOG = ?'; + push @bind, $catalog; + } if (defined $schema) { push @where, 'TABLE_SCHEMA = ?'; diff --git a/t/40keyinfo.t b/t/40keyinfo.t index 80b5aa5b..5991b0d7 100644 --- a/t/40keyinfo.t +++ b/t/40keyinfo.t @@ -43,11 +43,16 @@ is_deeply([ $dbh->primary_key(undef, undef, 'dbd_mysql_keyinfo') ], [ 'a', 'b' ] $sth= $dbh->statistics_info(undef, undef, 'dbd_mysql_keyinfo', 0, 0); my $stats_info = $sth->fetchall_arrayref; +my $n_catalogs = @$stats_info; my $n_unique = grep $_->[3], @$stats_info; $sth= $dbh->statistics_info(undef, undef, 'dbd_mysql_keyinfo', 1, 0); $stats_info = $sth->fetchall_arrayref; my $n_unique2 = grep $_->[3], @$stats_info; isnt($n_unique2, $n_unique, "Check statistics_info unique_only flag has an effect"); +$sth= $dbh->statistics_info('nonexist', undef, 'dbd_mysql_keyinfo', 0, 0); +$stats_info = $sth->fetchall_arrayref; +my $n_catalogs2 = @$stats_info; +isnt($n_catalogs2, $n_catalogs, "Check statistics_info catalog arg has an effect"); ok($dbh->do("DROP TABLE dbd_mysql_keyinfo"), "Dropped table");